umgc / fall2022

SWEN 670 Fall 2022 cohort
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

Feature/mail piece edits #640

Closed sHuber125 closed 2 years ago

sHuber125 commented 2 years ago

I just worked on updating a couple items. I made it so that mail_fetcher processes the mailpieces and finds the usps mail ID (different from scanned image CID). I made another field for a mailpiece and updated everything that had a mailpiece use, so it has this extra value. I think if you are ok with what I have I would want everyone that worked on their particular items to make sure they all still work ok. Seems to work ok on my end.

I also removed all extraneous debugPrints from my work. I also updated the mailPiece indiv view code because now I don't have to find the mail ID to get the reminder and tracking links, as it is stored with the mailPiece. You can get other email data using a similar strategy, but I think for what we are doing you don't need the campaign ID or user physical address ID.

Also noticed a couple a runtime error after initially posting PR, fixed that and it correctly loads tracking and reminder links for each mailpiece now. *fixed the test error it was getting, one of the tests wasn't passing, just needed to update something in the test file for adding the extra mailpiece parameter.