Setting textFieldBackgroundColor changes the height

umhan35 / react-native-search-bar

The high-quality iOS native search bar for react native.

MIT License

867 stars 209 forks source link

Setting textFieldBackgroundColor changes the height #115

Closed samdiaz closed 6 years ago

samdiaz commented 7 years ago

The height gets changed to 34, when it should be 30.

See lines 80-85 in RNSearchBarManager.m.

// Add a clip before drawing anything, in the shape of an rounded rect
[[UIBezierPath bezierPathWithRoundedRect:CGRectMake(0,0, 34, 34)
                            cornerRadius:5.0] addClip];`

Happy to submit a PR fixing this.

iRoachie commented 6 years ago

Hey @samdiaz new maintainer here. We recently release v3.1.0, if this is still happening then ping me to reopen this issue or create a new issue.