search

umhan35 / react-native-search-bar

The high-quality iOS native search bar for react native.
MIT License
862 stars 207 forks source link

Add Cocoapods support & removed deprecated React.Proptypes reference #118

Closed RobertBiehl closed 6 years ago

RobertBiehl commented 7 years ago

I added a *.podspec for this project so people who are using Cocoapods with React can integrate it more easily.

RobertBiehl commented 7 years ago

@umhan35 Can you please merge this? It's a great help for Cocoapods users.

bkvirendra commented 7 years ago

@RobertBiehl maybe you want to update the package.json file to include the ReactNativeSearchBar.podspec in the package on getting published.

RobertBiehl commented 7 years ago

@bkvirendra Do you mean updating the app version? The package.json does not seem to reference any files, or did I miss something?

iRoachie commented 6 years ago

Hey @RobertBiehl new maintainer here. We recently released v3.1.0 so now your changes are out of sync with latest. Can you rebase your branch against the next branch?

iRoachie commented 6 years ago

I merged your commit @RobertBiehl in https://github.com/umhan35/react-native-search-bar/commit/c2499e8894b83f313dbf0bd2b3c36b53efed4bd6. Will be available in next release. Thanks again.