search

umhan35 / react-native-search-bar

The high-quality iOS native search bar for react native.
MIT License
862 stars 207 forks source link

Deprecate React.createClass #125

Closed iRoachie closed 6 years ago

iRoachie commented 7 years ago

React 0.15.5 deprecated React.createClass and will be removed completely in a newer version of react. Since react-native@0.45, this now shows as an error when the apps are running. https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#new-deprecation-warnings

The React team has provided a drop-in replacement for React.createClass as a separate library called "create-react-class".

This PR replaces React.createClass with createReactClass

machour commented 6 years ago

+1

vonovak commented 6 years ago

@umhan35 please merge so the package can be used with rn 0.49

andrewda commented 6 years ago

@vonovak doesn't look like he's been on GitHub since February. Might be best to make a fork and use that, instead. This is what we're using right now for GitPoint: https://github.com/andrewda/react-native-search-bar

nerdmed commented 6 years ago

@umhan35 you are there? If not @vonovak @iRoachie anyone interested in releasing to npm - we can spread the new package to get adoption!

vonovak commented 6 years ago

@nerdmed I have requested the npm package name so we'll probably be able to keep the name and continue development in some fork. More in #128

iRoachie commented 6 years ago

Can we post a fork on npm with the same name??

iRoachie commented 6 years ago

Maybe as a scoped public package? https://docs.npmjs.com/getting-started/scoped-packages What you guys think?

vonovak commented 6 years ago

@iRoachie we cannot as of now, but we will be able to do so once npm support transfers the package ownership on to me. It will take two or three weeks - they're waiting to see if @umhan35 responds to their email and if not they will make it happen.