search

umiddelb / z2d

Zero 2 Docker with Ubuntu Core, Debian 9, Devuan, Fedora 28 or CentOS 7
144 stars 37 forks source link

double ubuntu-minimal, isc-dhcp-client already included inside #3

Closed Nerten closed 8 years ago

Nerten commented 8 years ago

Small pretty changes for ubuntu packages

umiddelb commented 8 years ago

Thank you for the PR. I believe there is much room for refactoring inside of common/common-functions.sh. I'm fine with all commits, except of a790602. I needed to hard-wire this kernel version, because subsequent versions don't have aufs support included (and you cannot easily switch it on again). Docker will run without aufs support but it isn't that much fun.

Nerten commented 8 years ago

Oh, thank you. I going to figure it out with docker. I'll to revert back this commit. I saw your discussion about aufs, but missed to keep it in my mind.

Nerten commented 8 years ago

Now this pull request ready for merge.

umiddelb commented 8 years ago

Thank you. You have introduced sudo usermod -aG docker $SUDO_USER. I've used this before but experienced that $SUDO_USER might be empty in non-interactive environments. So I've reverted this back.

And as long as debian or ubuntu are still hard-wired in the ...-02.sh scripts, it doesn't hurt that much.

Nerten commented 8 years ago

Ok, reverted it too. Sadly there is no working method to find current username. But now I am working on feature with system settings config which may help.

umiddelb commented 8 years ago

Thank you!