search

umijs / babel-plugin-import

Modularly import plugin for babel.
3.15k stars 403 forks source link

Rewrite v2 #543

Closed yesmeck closed 2 years ago

yesmeck commented 3 years ago

Breaking change

Default imports and namespaced imports are no longer supported. 

import * as antd from 'antd'; // no longer supported
import antd from 'antd'; // no longer supported

Close

codecov-io commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3a93f5a). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #543   +/-   ##
=========================================
  Coverage          ?   94.28%           
=========================================
  Files             ?        1           
  Lines             ?       70           
  Branches          ?       30           
=========================================
  Hits              ?       66           
  Misses            ?        4           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a93f5a...8cbc7dc. Read the comment docs.

afc163 commented 3 years ago

@sorrycc 来看看？

sorrycc commented 3 years ago

和 https://github.com/ant-design/babel-plugin-import/pull/459 的处理方式一样，丢功能了。换这种方式，内部是不敢直接在框架里直接升的。

sorrycc commented 3 years ago

改名和顺序的问题，不换方案应该也是有解的。

yesmeck commented 3 years ago

不行我换个名字发个新包

yesmeck commented 3 years ago

一个想法，umi 里可以同时使用新旧两个版本，可以先用新版本转换一遍，再用旧版本去兜底 import * as antd from 'antd'; 的情况，并显示警告，后面 umi 升大版本再把旧版 babel-plugin-import 下掉。