search

umijs / mako

An extremely fast, production-grade web bundler based on Rust.
https://makojs.dev
MIT License
1.11k stars 42 forks source link

Better change Rust nightly to stable #1326

Open Boshen opened 6 days ago

Boshen commented 6 days ago

https://github.com/umijs/mako/blob/12b685b6cd735e1a2c9d7cacc4579ed9e450c141/rust-toolchain.toml#L3

This hasn't been updated for 8 months, and nightly features are accumulating technical debt that you will regret sooner or later because upgrading rustc will become tremendously hard, and you'll miss out all the nice LLVM optimizations from recent upgrades.

xusd320 commented 6 days ago

https://github.com/umijs/mako/blob/12b685b6cd735e1a2c9d7cacc4579ed9e450c141/rust-toolchain.toml#L3

This hasn't been updated for 8 months, and nightly features are accumulating technical debt that you will regret sooner or later because upgrading rustc will become tremendously hard, and you'll miss out all the nice LLVM optimizations from recent upgrades.

Thanks, we are using a bit low version of swc, which depents on "#![feature(box_patterns)]" of nightly rust, so before change to stable rust, we must upgrade the swc version, that will be a big challenge.

xusd320 commented 6 days ago

Ref: https://github.com/swc-project/swc/issues/8316