umijs / qiankun

📦 🚀 Blazing fast, simple and complete solution for micro frontends.
https://qiankun.umijs.org
MIT License
15.61k stars 2k forks source link

fix: cheerio move to dependencies #2867

Closed qiYuei closed 6 months ago

qiYuei commented 6 months ago

cheerio 应该放在 dependencies 才能正常运行 image

vercel[bot] commented 6 months ago

@qiYuei is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: a8cdf6a0f160656a876624be5bfb5bfa7c2895b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------- | ----- | | @qiankunjs/webpack-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

qiYuei commented 6 months ago

@kuitos 可能要重新发布下这个

kuitos commented 6 months ago

ci 修一下,pnpm lockfile 要更新

qiYuei commented 6 months ago

ci 修一下,pnpm lockfile 要更新

我在 create-qiankun 那个 pr 修了, 等那个 pr 合并还是在这里更新一次? 现在那边别的库 eslint 没过

image

kuitos commented 6 months ago

先修这个,这两个不是一个问题

qiYuei commented 6 months ago

先修这个,这两个不是一个问题

Done