search

umijs / umi

A framework in react community ✨
https://umijs.org
MIT License
15.06k stars 2.64k forks source link

fix(@umijs/plugins): model files may be collected more than once in some cases #12535

Closed liuwenzhuang closed 1 day ago

liuwenzhuang commented 6 days ago 
...this.getModels({
  base: join(this.api.paths.absPagesPath),
  pattern: '**/models/**/*.{ts,tsx,js,jsx}',
}),
...this.getModels({
  base: join(this.api.paths.absPagesPath),
  pattern: '**/model.{ts,tsx,js,jsx}',
})

model 文件的路径为 *src/pages/*/models/model.ts 时，这两个 pattern 会重复收集 model 文件。

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **umi** | ⬜️ Ignored ([Inspect](https://vercel.com/chenchengs-projects-4255bdcd/umi/7m8NM5zkDagXtN9ZTNryhKSqjXzv)) | [Visit Preview](https://umi-git-fork-liuwenzhuang-master-chenchengs-projects-4255bdcd.vercel.app) | | Jul 8, 2024 1:18am |
coderabbitai[bot] commented 6 days ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

这次变更主要涉及在 packages/plugins/src/utils/modelUtils.ts 中引入 lodash 来替代原先的扩展操作符进行数组操作。具体地，ModelUtils 类中构建 models 数组的逻辑从使用扩展操作符转换为使用 lodash.uniq 来确保文件路径的唯一性。

Changes

文件路径 变更摘要
packages/plugins/src/utils/modelUtils.ts 将原有的扩展操作符替换为 lodash.uniq 方法以确保模型路径唯一性，同时修改了相应的导入语句。

Sequence Diagram(s)

这次更改主要集中在代码内部的数组操作逻辑，并未显著影响控制流程，故无需生成时序图。

Poem

🐇代码变更漫天飞，
模型独一心不累。
lodash 加入真高效，
唯一路径常相随。
chalk 搭档也不累，
胜似云中兔儿飞。

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
fz6m commented 4 days ago

  1. 合并一下 master 最新的代码，原来的 CI 有问题。

  2. 不要直接添加 uniq 在上面，会造成一层缩进和大脑理解困难，拆成先获取文件列表（变量 1 ，如 modelFiles ），之后 uniq （变量 2 ，如 modelUniqFiles），再做 models 生成（现有变量）。

liuwenzhuang commented 2 days ago
  1. 合并一下 master 最新的代码，原来的 CI 有问题。
  2. 不要直接添加 uniq 在上面，会造成一层缩进和大脑理解困难，拆成先获取文件列表（变量 1 ，如 modelFiles ），之后 uniq （变量 2 ，如 modelUniqFiles），再做 models 生成（现有变量）。

已修改

sorrycc commented 1 day ago

e2e 挂了，我先 revert 下，有需要重新再提。

fz6m commented 7 hours ago

目测这里拿到全部路径之后需要进行一遍 winPath ，之后再 uniq ，不然 windows 的 e2e 就挂了 ？

有空的话可以再提交一遍试试。