Open umkatakam opened 9 years ago
Created an additional PR with some code clean up. https://github.com/umkatakam/blogger/pull/2 Since I did this after submission deadline. Haven't merged it and created it as a PR.
:+1: nice work. The goal of this assignment was to learn how to implement local authentication, interact with a data store, and render a webUI. In addition, you explored using middleware to facilitate common HTTP functionality. Over the next few weeks, we'll be focusing on more complex integrations and realtime functionality that we find in modern APIs and web apps.
Here's a checklist of things that I'm looking for in this project. You should review the checklist, and make any changes to your project, if necessary.
module.exports
. Your modules should reveal the minimum interface and only expose things that must be used by other modules.*Sync
calls anywhere in your code, and no require
calls except at the top of each module file."dependencies"
. When installing dependencies, use the --save
option: npm install --save somepackage
.req
or res
into a reusable composable middleware: (req, res, next)=>{}
.isLoggedIn
or equivalent route middleware: app.post('/post/:postId', isLoggedIn, ...)
My app is complete. //cc @codepathreview @codepath
List of features are detailed in the readme.
Please LMK what you think. Had a busy week could only finish the required features. Shall work and submit optional features and refactor the code into individual routes in couple of days.
Mahesh