Open stephematician opened 1 month ago
I added the test of opener->type
when setting ready-for-output (and decrementing ready-for-capture) in STREAMOFF.
I wouldn't mind some feedback about what the expected behaviour of ready-for-output and ready-for-capture are in order to tidy up the logic. Otherwise, happy to leave things as they are.
Allow repeated VIDIOC_REQBUF when no buffers are mapped (fix #598) by:
ready_for_output
back to 1 invidioc_streamoff
.vidioc_reqbufs
when ready-for-output is true.I hope I haven't messed up the logic for
dev->ready_for_output
. The comments suggest:More precisely, it looked to me like it was initialised as true and set to false (only) once
vidioc_streamon
is called - i.e. when the output process is started in streaming (memory mapping) I/O. Thus it should be safe to return it to true oncevidioc_streamoff
is called.I contemplated whether I also needed to add a check that the opener is assigned WRITER type in stream-off, but have left it out for now, e.g.: