search

umodoc / editor

Umo Editor is an open-source document editor, based on Vue3 and Tiptap.
https://editor.umodoc.com/en/docs
MIT License
330 stars 62 forks source link

Linting and Typing fixes #63

Closed Goldziher closed 2 months ago

Goldziher commented 2 months ago

This PR is a draft - meant to show the kind of changes I've implemented.

What it includes:

  1. Provide a thorough update on the lining setup and fix ALL ESlint issues.
  2. thorough fixes to the typescript and typescript setup of the project
  3. myriad cleanups and fixes of issues discovered via automated code inspection
  4. Up-to-date testing setup
  5. initial tests.

If you guys are happy with the changes happening in this PR, I will finish fixing all typescript issues and scaffold a few more tests for Vue components and other elements. My goal is to give you guys an excellent base to convert the entire vue side of the project to typescript by resolving the annoying vue-related issues (it's been like this for the past five years with vue and TS) and also giving you a few excellent examples of how tests can be added to the entire project.

please let me know if you want me to proceed and finish this PR.

umodoc commented 2 months ago

Thank you for submitting this draft PR. It's great to see the progress you've made so far. Please continue to complete the TypeScript issues and enhance the test coverage as you've outlined. We look forward to seeing the complete PR and appreciate your efforts to streamline and modernize our codebase. As there are many files involved in the changes, we may conduct more comprehensive testing of your changes after you submit the complete PR to prevent any unexpected situations. Thank you again for your contribution. To facilitate communication, this message has been translated by AI.

Goldziher commented 2 months ago

great @umodoc - i will close this PR for now, and make sure to resolve all conflicts before opening it again after I finish fixing the issues remaining. I will also sync my branch.