search

umontreal-simul / ssj

Stochastic Simulation in Java
http://umontreal-simul.github.io/ssj
Other
119 stars 43 forks source link

Possible issue in umontreal.ssj.functionfit.BSpline #2

Closed EXPEkmajewski closed 7 years ago

EXPEkmajewski commented 7 years ago

We have identified a possible issue in umontreal.ssj.functionfit.BSpline. We are not sure if it is in fact a bug in SSJ, or if we are using SSJ incorrectly. We have created the following GitHub repo to describe the issue in detail and show how to reproduce it:

https://github.com/EXPEkmajewski/ssj-issue

Thanks for taking a look!

chwyean commented 7 years ago

Hi there, We will take a look at it.

EXPEkmajewski commented 7 years ago

Thanks, appreciate it.

chwyean commented 7 years ago

Just to let you know that we're working on it. There is indeed a bug in the implementation of the approximation.

EXPEkmajewski commented 7 years ago

Good to know, thanks!

chwyean commented 7 years ago

We corrected the bug in the source code. Here's the difference. The green line is from the corrected function. The red line was from the bugged function. newgraph We also made the bisection more robust by checking the bounds before starting the search. The master branch has been updated. I still have to upload the new version on Maven central. Thanks for the bug report!

EXPEkmajewski commented 7 years ago

Thanks! I tried your hotfix with my test code (https://github.com/EXPEkmajewski/ssj-issue) and the results are very promising. It's a nice Christmas present for me :)

Are you guys planning to release this any time soon? It would make it easier for us to run SSJ in production if the latest version was available via Maven Central.

Thanks again for addressing the issue and sorry for the slow reply,

-krzys

From: chwyean notifications@github.com<mailto:notifications@github.com> Reply-To: umontreal-simul/ssj reply@reply.github.com<mailto:reply@reply.github.com> Date: Wednesday, November 30, 2016 at 8:33 PM To: umontreal-simul/ssj ssj@noreply.github.com<mailto:ssj@noreply.github.com> Cc: Krzysztof Majewski kmajewski@expedia.com<mailto:kmajewski@expedia.com>, Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [umontreal-simul/ssj] Possible issue in umontreal.ssj.functionfit.BSpline (#2)

We corrected the bug in the code source. Here's the difference. The green line is from the corrected function. [newgraph]https://cloud.githubusercontent.com/assets/15200507/20778448/afc434b8-b73b-11e6-8c03-eb84c07e07b9.jpeg We also made the bisection more robust by checking the bounds before starting the search. The master branch has been updated. I still have to upload the new package to Maven central. Thanks for the bug report!

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/umontreal-simul/ssj/issues/2#issuecomment-264052328, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQZ8CLShXV0fs3ijizylJV25eV9PBB1rks5rDiPigaJpZM4Kp3UI.

pierrelecuyer commented 7 years ago

We will put the fix in the next release, sometime in January. I will be working in California from Jan 6 to 22, so there is a chance that the next release will be only after that. Happy holidays. -- Pierre L.

On 12/29/2016 8:53 AM, Krzysztof Majewski wrote:

Thanks! I tried your hotfix with my test code (https://github.com/EXPEkmajewski/ssj-issue) and the results are very promising. It's a nice Christmas present for me :)

Are you guys planning to release this any time soon? It would make it easier for us to run SSJ in production if the latest version was available via Maven Central.

Thanks again for addressing the issue and sorry for the slow reply,

-krzys

From: chwyean notifications@github.com<mailto:notifications@github.com> Reply-To: umontreal-simul/ssj reply@reply.github.com<mailto:reply@reply.github.com> Date: Wednesday, November 30, 2016 at 8:33 PM To: umontreal-simul/ssj ssj@noreply.github.com<mailto:ssj@noreply.github.com> Cc: Krzysztof Majewski kmajewski@expedia.com<mailto:kmajewski@expedia.com>, Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [umontreal-simul/ssj] Possible issue in umontreal.ssj.functionfit.BSpline (#2)

We corrected the bug in the code source. Here's the difference. The green line is from the corrected function. [newgraph]https://cloud.githubusercontent.com/assets/15200507/20778448/afc434b8-b73b-11e6-8c03-eb84c07e07b9.jpeg We also made the bisection more robust by checking the bounds before starting the search. The master branch has been updated. I still have to upload the new package to Maven central. Thanks for the bug report!

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/umontreal-simul/ssj/issues/2#issuecomment-264052328, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQZ8CLShXV0fs3ijizylJV25eV9PBB1rks5rDiPigaJpZM4Kp3UI.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/umontreal-simul/ssj/issues/2#issuecomment-269633027, or mute the thread https://github.com/notifications/unsubscribe-auth/AKp1oyr1Dl-IQ4F9Uu6LP32V1bxe5pnMks5rM7t3gaJpZM4Kp3UI.

-- Pierre L'Ecuyer, Professeur Titulaire Chaire du Canada en Simulation et Optimisation Stochastique CIRRELT, GERAD, and DIRO, Université de Montréal, Canada http://www.iro.umontreal.ca/~lecuyer

chwyean commented 7 years ago

The bug fix was added previously in Pull #3, so I'm closing this issue.

chwyean commented 7 years ago

Hi @EXPEkmajewski, Just to tell you that we have released SSJ 3.2.1 with the bug fixes on Maven Central.