umotif-public / terraform-aws-elasticache-redis

A Terraform module to create an AWS Redis ElastiCache cluster.
https://registry.terraform.io/modules/umotif-public/elasticache-redis/aws
Other
40 stars 64 forks source link

Added ability to enable the prevent destroy option on the redis cluster #14

Closed seanpascual closed 3 years ago

seanpascual commented 3 years ago

Description

Added the lifecycle block to the redis cluster to allow the option to enable prevent_destroy. It is set to false by default

seanpascual commented 3 years ago

In looking into this issue, we've discovered that there's an open request on the aws terraform provider to allow the auth token to be updated without the redis cluster needing to be recreated. It appears that the code has been fixed, but it hasn't yet been approved and merged.

github.com/hashicorp/terraform-provider-aws/pull/16203

Another request of a similar manner. github.com/hashicorp/terraform-provider-aws/issues/15561

My PR would just be a workaround until the above fixes are implemented into the provider.

marcincuber commented 3 years ago

After an internal discussion, we decided not to support this feature until lifecycle block in terraform support variables.