umotif-public / terraform-aws-waf-webaclv2

Terraform module to configure WAF V2 Web ACL with managed rules for Application Load Balancer
https://registry.terraform.io/modules/umotif-public/waf-webaclv2/aws
Other
137 stars 124 forks source link

Added rate limiting evaluation window #131

Open ezafeire opened 7 months ago

ezafeire commented 7 months ago

Added the ability to define an evaluation window when creating a rate_based_statement in a rule.

Description

While implementing rate limit policies on WAF for a client, I realized that there was no way to lower the evaluation window that WAF uses to determine rate limiting requests to under 300 sec. With this PR you can modify it and if you don't it defaults to 300 sec (the default 5 minutes).

dmzeus commented 6 months ago

It's a minor change but much needed)

stavbernazport commented 6 months ago

This is very needed!! Took me some time to understand why it's not applying until I found out it's not yet supported by this module

stavbernazport commented 6 months ago

@splichy Can you please check if this can be released?

dmzeus commented 1 month ago

Any news here?)