umotif-public / terraform-aws-waf-webaclv2

Terraform module to configure WAF V2 Web ACL with managed rules for Application Load Balancer
https://registry.terraform.io/modules/umotif-public/waf-webaclv2/aws
Other
137 stars 124 forks source link

Fix for headers field_to_match #94 #95

Closed MatanHeledPort closed 1 year ago

MatanHeledPort commented 1 year ago

Description

Lookup for field_to_match in headers wasn't scanning keys. This should fix the issue #94

Please explain the changes you made here and link to any relevant issues. Changed : lookup(match_pattern.value, "all", {} to: lookup(keys(match_pattern.value), "all", {}

felipe88alves commented 1 year ago

Only suggestion would be to remove the not statement from the example to keep the scope of the test simpler, not a blocker from merging anyways.

In any case , I can't approve but lgtm

MatanHeledPort commented 1 year ago

@Ohid25 Would appreciate a review here (:

Ohid25 commented 1 year ago

Thank you for your contribution! This is now released as a part of 4.4.0.