search

umpirsky / Extraload

Powerful ETL library.
MIT License
34 stars 5 forks source link

extract() method update #19

Closed programarivm closed 6 years ago

programarivm commented 6 years ago

Hi there,

The doctrine code snippets work OK with MySQL but I noticed that rowCount() is not 100% reliable in all database vendors.

So, rather than relying on rowCount, I believe the extract() method in QueryExtractor has to control if $this->stmt->fetch() returns false as per Doctrine API documentation.

Many thanks,

programarivm commented 6 years ago

The return statement is removed from the extract() method. Many thanks.