#47 - Not working with TWIG ~1.24

umpirsky / Twig-Gettext-Extractor

The Twig Gettext Extractor is Poedit friendly tool which extracts translations from twig templates.

MIT License

113 stars 32 forks source link

#47 - Not working with TWIG ~1.24 #48

Open cheplv opened 7 years ago

cheplv commented 7 years ago

Add support for twig translations functions: trans and transchoice

umpirsky commented 7 years ago

@cheplv I think we should add this in README under setup, parser command so anyone can configure it and be more flexible over different twig versions.

Agree?

cheplv commented 7 years ago

@umpirsky As an additional information in README - yes. Currently this project is used for translations in many projects and if someone updates twig it silently doesn't gives any translations. So this 2 things: code + readme must to be added to this project.

umpirsky commented 7 years ago

@cheplv I would like to avoid code changes if possible, which means if something can be achieved using Poedit configuration, it should be done that way. If someone updates Twig and it stops working they can come to the project GitHub page and read note we added or post/search an issue and find information there.

People use this tool in many different ways and adding keywords to the code may limit some of use cases and decrease the flexibility of the tool.

Thanks.