umpirsky / centipede

:sparkler: The Simplest automated testing tool on Earth.
MIT License
141 stars 15 forks source link

Crash when parsing a link to a phone number #10

Closed gnutix closed 9 years ago

gnutix commented 9 years ago

When parsing my website with centipede run http://auxptitsplaisirs.lo/, I get the following exception :

[InvalidArgumentException]                                                     
  Unable to parse malformed url: http://auxptitsplaisirs.lotel:+41 21 907 26 26

Because it fails to parse the following link :

<a href="tel:+41 21 907 26 26">+41 21 907 26 26</a>
umpirsky commented 9 years ago

@gnutix Looks like invalid url to me, maybe <a href="#tel:+41 21 907 26 26">+41 21 907 26 26</a> is better?

gnutix commented 9 years ago

I will try using href="tel://0041768221794", like proposed here: http://code.tutsplus.com/tutorials/mobile-web-quick-tip-phone-number-links--mobile-7667

I'll get back to you ASAP.

umpirsky commented 9 years ago

Thanks! :+1:

gnutix commented 9 years ago

Centipede does not try to open the link anymore using tel://0041768221794. Thanks for pointing me in the right direction!

umpirsky commented 9 years ago

@gnutix Because host name is null, cool!