search

umpirsky / centipede

:sparkler: The Simplest automated testing tool on Earth.
MIT License
141 stars 15 forks source link

Optimize crawler #24

Closed Pierstoval closed 5 years ago

Pierstoval commented 9 years ago

Fixes #23

umpirsky commented 9 years ago

Very nice, thanks for your contribution @Pierstoval, really appreciate it. :+1:

This depends on https://github.com/umpirsky/centipede-crawler/pull/8, right, so I think we need to update composer dependency for the crawler composer update umpirsky/centipede-crawler.

If that does not work because of stability stable, just ping me after we merge PR and I will tag a new release.

umpirsky commented 9 years ago

Later I may extract request handling from this command and introduce formatters. :)

Pierstoval commented 9 years ago

There are still some bugs with ClientException, I'm gonna fix this, just wait a moment ;)

umpirsky commented 9 years ago

@Pierstoval In which cases is ClientException thrown?

Pierstoval commented 9 years ago

When the $response->getStatusCode() returns special errors. I tested on an url that returns a HTTP 406 error, and this function returned an exception.

It's fixed in ccbf04f

umpirsky commented 9 years ago

@Pierstoval Cool, so you can remove exception handling from centipede now?

Pierstoval commented 9 years ago

Done ! Also fixed depth rendering in both repositories

Pierstoval commented 5 years ago

I'm not sure I'm going to continue working on this, sorry. Anyone can take the work back if necessary.