umpirsky / country-list

:globe_with_meridians: List of all countries with names and ISO 3166-1 codes in all languages and data formats.
MIT License
5.18k stars 1.55k forks source link

Watch out USSR in the list! #41

Closed igsm closed 9 years ago

igsm commented 9 years ago

Union of Soviet Socialist Republics... you are kidding!

Thanks for snippet but after this (USSR) I will need to check each country if it is not a joke.

umpirsky commented 9 years ago

@igsm What file?

igsm commented 9 years ago

country-list/country/cldr/en/country.postgresql.sql

I usually come across with ~250 countries offered in the html select field. Your is 264.

I have uploaded mine. I pulled this list from one commercial website. Can't guarantee 100% accuracy but looks fine from the fist glance.

https://github.com/igsm/postgresql-country-list

umpirsky commented 9 years ago

@igsm I can't find USSR in https://github.com/umpirsky/country-list/blob/master/country/cldr/en/country.postgresql.sql?

igsm commented 9 years ago

line 249 - Union of Soviet Socialist Republics

igsm commented 9 years ago

I also checked one doubtful case - line 209: 'Serbia and Montenegro' and of course it is in the list. Now there are two separate countries, which are also included but you should remove S&M :)

umpirsky commented 9 years ago

@igsm I am from Serbia, no worries. :)

It's CLDR providing this regions.

You can consider using ICU data instead https://github.com/umpirsky/country-list/blob/master/country/icu/en/country.postgresql.sql.

igsm commented 9 years ago

Alrightttttt..... hah. Thanks

umpirsky commented 9 years ago

:+1: