umpirsky / country-list

:globe_with_meridians: List of all countries with names and ISO 3166-1 codes in all languages and data formats.
MIT License
5.16k stars 1.55k forks source link

JSON files fixed issue #62 #65

Closed ghost closed 7 years ago

ghost commented 7 years ago

Wrote a script that edited all JSON files so they fix issue #62. @umpirsky please review.

umpirsky commented 7 years ago

@kosanovic This repository uses https://github.com/umpirsky/list-generator to generate the list. So, the right thing to do would be to update https://github.com/umpirsky/list-generator/blob/master/src/Umpirsky/ListGenerator/Exporter/Format/Json.php to export according to new format and use that instead. Reason: If we do it like you proposed, changes will be lost on next build. So, here is how it goes:

  1. We update https://github.com/umpirsky/list-generator/blob/master/src/Umpirsky/ListGenerator/Exporter/Format/Json.php.
  2. Release new version of https://github.com/umpirsky/list-generator
  3. We update this repo to use new version (composer update ...)
  4. Then we build.

Thanks.