umple / AcademicTeamManagement

Web application used to manage capstone projects
https://academic-teams.umple.org
4 stars 0 forks source link

Group id should be unique within the UI and DB. The system allows the creation of two or more teams with the same ID. #332

Closed mgarzon closed 1 week ago

mgarzon commented 9 months ago

Group id should be unique within the UI and DB. The system allows the creation of two or more teams with the same ID.

mgarzon commented 9 months ago
MicrosoftTeams-image
Laith-Grira commented 9 months ago

The current system uses Formik to check if the group data is unique: https://github.com/umple/AcademicTeamManagement/blob/main/client/src/schemas/createGroupSchema.js#L9-L16 We check the current group name with all the group names that exist in the DB, if it's not unique, an error message appears

There might be an edge case where this error is not being caught

ellaprimeau commented 1 week ago

Solved in latest push to main, groups are now assigned consecutive group ids