search

umple / umple.gradle

Home for the Gradle plugin for Umple (gradle-umple-plugin)
MIT License
4 stars 0 forks source link

Expand test case coverage, improve existing tests #21

Open AdamBJ opened 7 years ago

AdamBJ commented 7 years ago
AdamBJ commented 7 years ago

@Nava2 Hey Kevin, I've got my plans more-or-less set for summer now. I'll be working full time, but would still like to continue with the test case stuff for the plugin we discussed at the end of last semester.

Unfortunately, my hard drive failed earlier this week, and with it went the development Gradle/Umple development environment. I'm going to try and get it up-and-running again, but my bandwidth over the summer will be limited. What're you plans for the summer? Are you planning to put any time in on Umple/Gradle?

Nava2 commented 7 years ago

So, I want to do some work on this project, getting it closer -- but I'm hurting for time with finishing up my thesis. I can probably take a more hands-off approach than I was before. I can also answer emails and do little things. 👍

AdamBJ commented 7 years ago

One thing we should address is how master is still something like 19 commits behind ss-config-n2. Hopefully we can merge it into master before the summer is over, but if we don't we should put out some big, loud signposts for whoever is working on this next. Wouldn't want them to start working on the master branch.

AdamBJ commented 7 years ago

My goal for the summer is: 1) Make sure the job of whoever starts on this project next is as easy as possible. Cleanup readme, add quickstart section etc so that the next person can get up and running as quickly as possible. 2) Check off as many of the boxes in the above list as possible.

AdamBJ commented 7 years ago

@Nava2 what version of gradle are you using when working with the Umple plugin? I've been getting some weird org.gradle.tooling.BuildException: Could not execute build using Gradle distribution 'https://services.gradle.org/distributions/gradle-3.4.1-bin.zip'. errors and am wondering if it's because I've upgraded to a newer version of gradle.

AdamBJ commented 7 years ago

Never mind, it was related to another issue.

Nava2 commented 7 years ago

Good because I also forgot to reply.. 😥

AdamBJ commented 7 years ago

@Nava2 Alright, I think I've fixed the problem I was having, but I've come across something perplexing. If I recall correctly, the command:

$ java -jar umple-latest.jar -c -g master.ump

Should generate whichever .java files are encoded by master.ump, and then compile them into .class files. However, I'm only getting .java files out right now. What gives? It's messing with the gradle test cases because the way we set it up we look for both .java and .class files when compileGenerated is set (which is it by default).

Nava2 commented 7 years ago

I don't think Umple uses javac at all. So, just Java is the expectation.

Nava2 commented 7 years ago

I actually built this awhile ago, it might be useful to read through it. I did many of the things I wanted to so with this plugin within.

https://github.com/assertj/assertj-generator-gradle-plugin

I have some other projects to finish at the moment (Masters' defence is on Monday), but I can probably look at this shortly. 👍

AdamBJ commented 7 years ago

Wow! Good luck on Monday! I'll have a look at the other plugin as I (hopefully) start adding more tests in the coming days.

Here are the lines that check for the .class files: https://github.com/umple/umple.gradle/blob/c577ee93d7f0ddb8f5babd5eb561924e70216c5f/src/integrationTest/groovy/CompilationAndGeneration.groovy#L19

Were we doing something extra to compile the .java files? I can't remember.

TimLethbridge commented 7 years ago

Inr reply to the earlier question. The correct way to compile is

java -jar umple-latest.jar master.ump

That will generate java files (no -c or -g options)

If you want classfiles then

java -jar umple-latest.jar -c - master.ump
Nava2 commented 7 years ago

My memory failed me, thanks @TimLethbridge.

TimLethbridge commented 7 years ago

No I mean -c - not -c -g

TimLethbridge commented 7 years ago

Sorry I was responding to what I think was a private message where I was asked if my comments were correct. I don't see that message above