search

umputun / feed-master

Pulls multiple podcast feeds (RSS) and republishes as a common feed, properly sorted and podcast-client friendly.
https://feed-master.umputun.dev
MIT License
118 stars 26 forks source link

consolidate configuration #81

Closed prybalko closed 1 year ago

prybalko commented 2 years ago

see #70

umputun commented 2 years ago

I have found use-cases for single-feed configuration and we can't drop it yet

prybalko commented 2 years ago

Just curious, that's the use case? It seems to be just a special case of multi-feed configuration.

Having a no-conf mode raises the question of where to store the telegram config. It doesn't use the yaml config, so it has to be done via env variables or cli args. But in this case, we end up where we started and this ticket doesn't make sense anymore. Or it's ok to have 2 equivalent ways for configuration: yml file and cil/env options?

umputun commented 2 years ago

the use case is kind of strange - to publish updates on feed change to both tg and twitter. This is how some of my podcasts do it. The reason why I have added this mode back in days - I wanted as simple as possible thingy to be fully defined in the docker-compose.yml (via the environment) without a need to maintain one more configuration file.

Probably we can go with a breaking change here and enforce the configuration yml file for those cases too.

prybalko commented 2 years ago

Is this PR still needed? Any comments/suggestions?

umputun commented 2 years ago

still not decided yet, need time to see what it looks like to switch a real single-mode setup to the full one