search

umputun / remark42

comment engine
https://remark42.com
MIT License
4.84k stars 376 forks source link

6px Body Padding #1487

Open paskal opened 2 years ago

paskal commented 2 years ago

Discussed in https://github.com/umputun/remark42/discussions/1465

Originally posted by **Ivan-Chupin** August 23, 2022 I've noticed that Remark42 doesn't fit perfectly into the frame intended for it. Remark.css -> body{padding:6px} was to blame. I think this is wrong, because such indents should be carried out exclusively by the layout designer of the site.

@paskal Unfortunately, I have no experience with jsfiddle, and besides, it is not available in the country where I am located. Therefore, I will try to explain in words and pictures.

If I put a Remark42 in a <div></div> then I naturally expect the Remark42 elements to align to the edges of the div. But since Remark42 uses a 6 point padding from each side of the div, this breaks the layout design.

Left as it is now, right as it should be: Remark42-Padding-2 Why does Remark42 use body{padding: 6px}? Why is the padding not 2 or 10? The answer is absolutely obvious - because it is a crutch that masks the incorrect layout of Remark42.

I think it's a valid issue worth addressing.

state303 commented 9 months ago

Any updates on this issue? I know the fix may be a bit trivial, but is somewhat bogging my mind.