search

umputun / remark42

comment engine
https://remark42.com
MIT License
4.84k stars 376 forks source link

Incorrect iframe height when `no_footer` enabled #1552

Closed domw95 closed 1 year ago

domw95 commented 1 year ago

When displaying the embed widget, the bottom of the widget up to the "reply" text on the bottom comment is cut off, I am guessing because the iframe height is too small. Manually setting the iframe height fixes the issue.

Tested on firefox desktop/mobile and chrome desktop.

Tried different versions (docker), and breaking change occurs between v1.11.0 and 1.11.1

Screenshot from 2022-12-14 02-48-04

Ivan-Chupin commented 1 year ago

Does version 1.11.2 have the same effect?

domw95 commented 1 year ago

Yes it does, sorry I didn't make that clear

akellbl4 commented 1 year ago

@domw95 could you please provide a link to a page with this problem?

domw95 commented 1 year ago

Example with just the comments on the page here https://test.domwil.co.uk/comments.html, server set to v1.11.2

akellbl4 commented 1 year ago

@domw95 thanks, it helped. I figured out the problem, we didn't account for no_footer option. I'm gonna work on a fix.

domw95 commented 1 year ago

I don't think that is the issue, it also occurs when no_footer is set to false

akellbl4 commented 1 year ago

@domw95 here is example on your instance with footer https://remark.domwil.co.uk/web/

domw95 commented 1 year ago

@akellbl4 Ok I've just had a play around and setting no_footer: false behaves the same as no_footer: true. Removing no_footer from the config fixes the height issue

paskal commented 1 year ago

Fixed with #1569, will be released shortly as a bugfix version (v1.11.3).