umputun / remark42

comment engine
https://remark42.com
MIT License
4.84k stars 376 forks source link

fix: fix no footer param #1567

Closed akellbl4 closed 1 year ago

akellbl4 commented 1 year ago

Pull the param from query and transform from string to boolean.

btw I don't know why do we have remark_config inside the iframe which is bad.

codecov[bot] commented 1 year ago

Codecov Report

Base: 62.35% // Head: 58.63% // Decreases project coverage by -3.71% :warning:

Coverage data is based on head (bf818fb) compared to base (6ac7503). Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1567 +/- ## ========================================== - Coverage 62.35% 58.63% -3.72% ========================================== Files 139 128 -11 Lines 3421 2877 -544 Branches 803 730 -73 ========================================== - Hits 2133 1687 -446 + Misses 1090 1065 -25 + Partials 198 125 -73 ``` | [Impacted Files](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun) | Coverage Δ | | |---|---|---| | [...rontend/apps/remark42/app/components/root/root.tsx](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tcG9uZW50cy9yb290L3Jvb3QudHN4) | `0.00% <0.00%> (ø)` | | | [...nd/apps/remark42/app/components/auth/auth.hooks.ts](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tcG9uZW50cy9hdXRoL2F1dGguaG9va3MudHM=) | `89.18% <66.66%> (-1.84%)` | :arrow_down: | | [frontend/apps/remark42/app/common/settings.ts](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tbW9uL3NldHRpbmdzLnRz) | `90.47% <100.00%> (+0.47%)` | :arrow_up: | | [frontend/apps/remark42/app/utils/post-message.ts](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvdXRpbHMvcG9zdC1tZXNzYWdlLnRz) | `66.66% <100.00%> (+16.66%)` | :arrow_up: | | [frontend/apps/remark42/app/common/cookies.ts](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tbW9uL2Nvb2tpZXMudHM=) | `21.05% <0.00%> (-2.76%)` | :arrow_down: | | [frontend/apps/remark42/app/common/api.ts](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tbW9uL2FwaS50cw==) | `72.09% <0.00%> (-0.64%)` | :arrow_down: | | [frontend/apps/remark42/app/common/fetcher.ts](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tbW9uL2ZldGNoZXIudHM=) | `94.82% <0.00%> (-0.09%)` | :arrow_down: | | [frontend/apps/remark42/app/common/types.ts](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tbW9uL3R5cGVzLnRz) | `100.00% <0.00%> (ø)` | | | [frontend/apps/remark42/app/hooks/useTheme.ts](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvaG9va3MvdXNlVGhlbWUudHM=) | `100.00% <0.00%> (ø)` | | | ... and [16 more](https://codecov.io/gh/umputun/remark42/pull/1567?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.67 KB (-0.02% 🔽)
public/remark.css 8.12 KB (0%)
public/last-comments.mjs 35.63 KB (+0.04% 🔺)
public/last-comments.css 3.72 KB (-0.03% 🔽)
public/deleteme.mjs 12.05 KB (+0.07% 🔺)
public/counter.mjs 749 B (0%)