search

umputun / remark42

comment engine
https://remark42.com
MIT License
4.84k stars 376 forks source link

Telegram QR is not legible #1622

Closed Darkyenus closed 1 year ago

Darkyenus commented 1 year ago

With dark theme, the QR code is not easily scannable due to two problems: image

  1. The QR code is not square because of the CSS class (this is not a problem for scanning, just ugly)

    .N_Q {
display: block;
margin: 12px auto;
width: 75%;
}

  2. (the important one) The QR code has no border, which is mandatory by the QR code specification, likely removed by #1276

Browser: Firefox 111, Windows

paskal commented 1 year ago

Thanks for the report! @akellbl4 could you please fix both problems with CSS? I think that we should better return borderless QR and add it in the frontend.

paskal commented 1 year ago

It should be good now. Please comment if things still aren't good enough.

image