search

umputun / remark42

comment engine
https://remark42.com
MIT License
4.84k stars 376 forks source link

fix: ui error when no auth providers configured #1640

Open Jaskon opened 1 year ago

Jaskon commented 1 year ago

This issue

image

Please correct me if i'm wrong: view variable (telegram/token/email) is only exist after some action in the dropdown menu. So its not necessary to check here that view is equal to something and checks provided in my PR is enough

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% :tada:

Comparison is base (c9b6f92) 61.55% compared to head (74fd5a8) 61.57%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1640 +/- ## ========================================== + Coverage 61.55% 61.57% +0.02% ========================================== Files 133 133 Lines 3004 3006 +2 Branches 752 761 +9 ========================================== + Hits 1849 1851 +2 - Misses 1038 1151 +113 + Partials 117 4 -113 ``` | [Files Changed](https://app.codecov.io/gh/umputun/remark42/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun) | Coverage Δ | | |---|---|---| | [...pps/remark42/app/components/auth/auth.messsages.ts](https://app.codecov.io/gh/umputun/remark42/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tcG9uZW50cy9hdXRoL2F1dGgubWVzc3NhZ2VzLnRz) | `100.00% <ø> (ø)` | | | [...rontend/apps/remark42/app/components/auth/auth.tsx](https://app.codecov.io/gh/umputun/remark42/pull/1640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun#diff-ZnJvbnRlbmQvYXBwcy9yZW1hcms0Mi9hcHAvY29tcG9uZW50cy9hdXRoL2F1dGgudHN4) | `81.69% <100.00%> (+0.26%)` | :arrow_up: | ... and [24 files with indirect coverage changes](https://app.codecov.io/gh/umputun/remark42/pull/1640/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Umputun)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paskal commented 3 months ago

@Jaskon can you please finalise that PR so that we could merge it?