Comment content styles - Githubissues

umputun / remark42

comment engine

https://remark42.com

MIT License

4.81k stars 374 forks source link

Comment content styles #1704

Closed akellbl4 closed 7 months ago

akellbl4 commented 9 months ago

Resolves https://github.com/umputun/remark42/issues/1629
Composes dark and light theme styles in one place
Moves syntax styles into content styles file
Adds colors to block with code only when pre > code (the way chroma generates html)
Fixes size of text in code block. Previously pre had size 85% and code had 85% from it.
Fixes code syntax highlight colors in dark mode (previously colors from light theme were used)
Minor syntax highlight colors adjustmests in dark mode for better contrast

Before

After

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (884b568) 65.20% compared to head (f24d044) 61.47%. Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1704 +/- ## ========================================== - Coverage 65.20% 61.47% -3.74% ========================================== Files 141 132 -9 Lines 3512 2998 -514 Branches 824 757 -67 ========================================== - Hits 2290 1843 -447 Misses 1038 1038 + Partials 184 117 -67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 9 months ago

size-limit report 📦

Path	Size
public/embed.mjs	2.03 KB (0%)
public/remark.mjs	73.45 KB (-0.03% 🔽)
public/remark.css	8.26 KB (-0.3% 🔽)
public/last-comments.mjs	35.72 KB (-0.05% 🔽)
public/last-comments.css	3.75 KB (-0.86% 🔽)
public/deleteme.mjs	12.07 KB (0%)
public/counter.mjs	751 B (0%)

github-actions[bot] commented 7 months ago

Pull Request Test Coverage Report for Build 7512286614

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.793%

Totals
Change from base Build 7495000583:	0.0%
Covered Lines:	5916
Relevant Lines:	6977