umputun / remark42

comment engine
https://remark42.com
MIT License
4.77k stars 375 forks source link

The "Delete" button remains visible in the UI even after the editing period has expired. #1737

Closed yakimka closed 4 months ago

yakimka commented 5 months ago

Steps to reproduce:

  1. Write a comment in remark42.
  2. Wait until the editing time is over.
  3. Click the "Delete" button.
  4. Nothing happens (as a user, I'm confused because there are no pop-ups or error messages).

Expected result:

зображення
umputun commented 5 months ago

@akellbl4 @paskal - I think it worked before; some regression?

paskal commented 5 months ago

@akellbl4, the problem was introduced in the 58b0841360c742647243346c5faa183908e082ed. I found this out using git bisect.

paskal commented 4 months ago

The "Delete" button should not be visible in the UI after the editing period has expired.

That option is the right one and was in place before the commit, where it was broken. It will be fixed shortly in the next release. Affected versions 1.10.0 - 1.12.1.