search

umputun / remark42

comment engine
https://remark42.com
MIT License
4.77k stars 375 forks source link

Check /status before getting user details #1752

Closed paskal closed 3 months ago

paskal commented 4 months ago

Resolves #1188 at the cost of one extra /auth/status call for authorised users and replacing /API/v1/user call with /auth/status for unauthorised users.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 61.39%. Comparing base (e1173bb) to head (d432667). Report is 9 commits behind head on master.

Files Patch % Lines
frontend/apps/remark42/app/common/api.ts 16.66% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1752 +/- ## ========================================== - Coverage 61.47% 61.39% -0.09% ========================================== Files 132 132 Lines 2998 3002 +4 Branches 715 716 +1 ========================================== Hits 1843 1843 - Misses 1151 1155 +4 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 73.47 KB (+0.03% 🔺)
public/remark.css 8.26 KB (+0.02% 🔺)
public/last-comments.mjs 35.72 KB (0%)
public/last-comments.css 3.75 KB (0%)
public/deleteme.mjs 12.09 KB (+0.16% 🔺)
public/counter.mjs 751 B (0%)