add RTL support - Githubissues

umputun / remark42

comment engine

https://remark42.com

MIT License

4.84k stars 376 forks source link

add RTL support #1799

Closed adueck closed 2 weeks ago

adueck commented 1 month ago

This pull request adds support for RTL (right-to-left) languages. By adding dir=auto to the relevant inputs, divs and textareas you get automatic support of RTL languages, with no detriment or loss in functionality to LTR languages.

See this excellent summary PSA: Add dir="auto" to your inputs and textareas.

Before:

After:

adueck commented 1 month ago

Thanks for approving this! Looks like there's just an issue with the dependencies for the tests to run?

failed to solve: mcr.microsoft.com/playwright:v1.44-jammy: failed to resolve source metadata for mcr.microsoft.com/playwright:v1.44-jammy: mcr.microsoft.com/playwright:v1.44-jammy: not found

paskal commented 1 month ago

Playwright will be fixed in #1802.

paskal commented 1 month ago

@akellbl4 can you please look into pnpm problem? It's not related to the changes in the PR.

adueck commented 1 month ago

Hmm, sorry did I do something wrong when I did pnpm install in my fork? If you want I could do another fork/pull request without touching pnpm and see if all the checks pass smoothly.

paskal commented 1 month ago

You did nothing wrong, I think master branch is broken at the moment.

paskal commented 2 weeks ago

@umputun let's merge this one, seems like checks are broken in master: we will deal with them later.