search

umputun / remark42

comment engine
https://remark42.com
MIT License
4.84k stars 376 forks source link

fix: Apple login integration #1806

Closed tomy0000000 closed 2 weeks ago

tomy0000000 commented 1 month ago

As mentioned in #1789, Apple login was broken in #1617.

I removed the problematic lines, recompiled a docker image, and confirmed the bug was indeed caused by the wrong ResponseMode params.

In addition, I've also improved some sections of docs about how to configure credentials used by Apple integration. One thing worth mentioning is that the term "Client ID" used by remark42 does not appear in Apple's developer dashboard but is used in some documentation, which can cause some confusion. Therefore, I added an annotation indicating that the "Client ID" can be either "App ID" or "Service ID".

resolves #1789

tomy0000000 commented 1 month ago

resolves #1789

tomy0000000 commented 1 month ago

Done! See also https://github.com/go-pkgz/auth/pull/212

tomy0000000 commented 2 weeks ago

@paskal @umputun Got some time to review this?