umputun / remark42

comment engine
https://remark42.com
MIT License
4.89k stars 378 forks source link

Error in IE11 #298

Closed leem32 closed 5 years ago

leem32 commented 5 years ago

When I load the comments (latest remark master branch ) in IE11 I get an error in the console:

Object doesn't support this action
var i=new Promise(function(t,n){o=r[e]=[t,n]});
File: remark.js, Line: 1, Column: 629

The comments just show the loader.

I don't have this problem in any other browser I've tested.

Does remark still support IE11?

I tried using the pollyfill.io default pollyfill which contains the promises pollyfill, but the error still occurs.

EDIT: If I load remark in IE11 on the demo page at https://remark42.com/demo/ the comments also fail to load and the console show an error:

Unhandled promise rejection Error: Loading chunk 5 failed.
(error: https://remark42.com/demo/vendors~polyfills.js)
"Unhandled promise rejection"
[object Error]{description: "Loading chu...", message: "Loading chu...", name: "Error", request: "https://rem...", stack: "Error: Load...", type: "error"}

You may already be aware of that error, but I thought I'd mention it as it's also a promise error like the error I have in my code.

leem32 commented 5 years ago

Any plans on getting remark working with IE11, or is that browser not supported anymore?

umputun commented 5 years ago

I'm not sure. From one hand it is about 5% of the market, from the over - even MS is saying you shouldn't use IE 11 unless you have a very specific need. Unless the fix is really trivial I'd say nay. @Reeywhaar - what say you?

Reeywhaar commented 5 years ago

I'm going to check everything on old ios versions (9.3), as for IE, well I'd be glad to support, I'll see what I can do

Reeywhaar commented 5 years ago

@leem, I have tested yesterday and #313 was merged. Can you check please, if there any issues in ie11? I suspect there can be some related to proxying, because ie doesn't work with dev setup, dev server proxied request constantly gets ECONNRESET, so I guess nginx backed remark can get same issues

leem32 commented 5 years ago

Sorry for the delay, I was away from computer. I've tested remark in ie11, but are getting the same error.

Object doesn't support this action
var i=new Promise(function(t,n){o=r[e]=[t,n]});
File: remark.js, Line: 1, Column: 629

To make sure I was using updated remark I completely removed the remark container and image from Docker and reinstalled the Git repo then ran docker-compose pull && docker-compose up -d.

leem32 commented 5 years ago

Just noticed however the remark demo page is now working with ie11. Maybe I've installed the remark update incorrectly?

leem32 commented 5 years ago

I've fixed this now. The comments are working in ie11. Thanks :) In case your wondering, the problem was caused by me having the image in docker-compose.yml set to latest when it needs to be set to master.

change image: umputun/remark42:latest to image: umputun/remark42:master.

umputun commented 5 years ago

cool, closing.