search

umputun / remark42

comment engine
https://remark42.com
MIT License
4.84k stars 376 forks source link

Demo page won't work If custom SITE variable was used #567

Open akellbl4 opened 4 years ago

akellbl4 commented 4 years ago

site_id (it is named just site on backend) was hardcoded in the template frontend/index.ejs and when you change it in docker-compose.ymlit won't work with backend because another site was defined.

When you try to post a comment it won't work because backend isn't able to add a comment to undefined site.

Example: https://remark42.mineev.me/web/

Screenshot Screenshot 2020-01-19 at 00 04 29
akellbl4 commented 4 years ago

@umputun we can pass env variable to the template but only on build because on a start we already have built static files. Maybe we can change site in the template on start by sed.

paskal commented 4 years ago

No sed, please. Env variable?

akellbl4 commented 4 years ago

Env variable?

As I see only on the build. A static HTML can't able to get any var from any place.

@Mavrin maybe you have some fresh ideas connected with it?