umputun / remark42

comment engine
https://remark42.com
MIT License
4.93k stars 386 forks source link

Disabling negative voting result causes lack of signs #727

Open umputun opened 4 years ago

umputun commented 4 years ago

Enabling POSITIVE_SCORE changes existing votes as well. This is expected (I guess) but confusing side-effect.

nbqwyv3bqe-20200607-131121

Not sure how to deal with this, but can think of 3 possible solutions:

  1. do nothing
  2. UI not just loose +/- on POSITIVE_SCORE, but also shows all negative values as 0s
  3. UI checks if any vote for the post negative and shows +/- in this case (POSITIVE_SCORE mode only)

/cc @paskal @akellbl4 @Mavrin

umputun commented 4 years ago

/re #260

akellbl4 commented 4 years ago

In my opinion only positive scores should have different view with like button or something like that. Downvote button in this situation absolutely useless.

The second thing if we show downvoted comments as zero-voted it will be strange just because upvoting will do nothing if comment is downvoted. Please correct me if I’m wrong.

umputun commented 4 years ago

Downvote button in this situation absolutely useless.

No, it is not. The positive-only score allows both positive and negative voting it just limits "negative" value to 0

The second thing if we show downvoted comments as zero-voted it will be strange just because upvoting will do nothing if comment is downvoted.

good point.

akellbl4 commented 4 years ago

Okay, I didn’t catch idea from the first time, now I understand. I thought it means you could vote only positive.

I think current behavior is predictable for current situation, the only thing I could make is to make downvote button a bit transparent (disabled state), and it will show that this button isn’t clickable without hovering.

umputun commented 4 years ago

the issue I'm having is not a behavior but how it shows the existing negative scores. Both negative and positive are very similar due to the lack of sign and the color-blinded users won't even notice the difference. If conditional signs (3) not that easy to implement maybe we should show a negative score with some other style change, like italic, underscored, or smth like this.

esvyridov commented 3 years ago

I think that another possible solution can be rendering negative score as it is (with "-" sign), but the downvote button must be disabled. In other words, transition from POSITIVE_SCORE from false to true will not have any effect on score of existing comments, even if they were downvoted, but these comments can be upvoted only. Score behaviour of new comments won't be changed (disabled downvote button).