umputun / remark42

comment engine
https://remark42.com
MIT License
4.82k stars 374 forks source link

Multiple admin emails #756

Closed dkornilove closed 3 years ago

dkornilove commented 4 years ago

Hello! I have a couple of managers that should be notified about all the new comments via email. But as I see I can set only one admin email at the ADMIN_SHARED_EMAIL variable. Is there any way to configure multiple admin emails? Thanks

umputun commented 4 years ago

Currently, there is no way to define multiple admin emails. This is something I'd like to add, but for now you have two workarounds:

umputun commented 4 years ago

@paskal let me know if you want to deal with this one. It seems to be a trivial change:

  1. Change AdminGroup.Email (both shared and RPC) to the slice / repeated
  2. Change rest.AdminEmail to slice
  3. Change notify.Request to support slice of emails or send one-by-one from createCommentCtrl
paskal commented 4 years ago

ETA ~1 week.

paskal commented 3 years ago

@dkornilove my apologies, it took longer than I anticipated. After linked MR will be merged you'll have ability to set up multiple emails for notifications.

dkornilove commented 3 years ago

@paskal , @umputun Thanks for the attention! But sadly I am not able to get it work with this env variable defined: - ADMIN_SHARED_EMAIL=exam.ple@mail1.com,example2@mail2.ru Emails are not sent. Only this working for me - ADMIN_SHARED_EMAIL=example@mail.com Im using last master version

paskal commented 3 years ago

@dkornilove, the first variant should work. Would you be so kind as to post docker-compose log around the time the message supposed to be sent to these emails? There should be something from notification part of the program at least trying to send them.