search

umputun / tg-spam

Anti-Spam bot for Telegram and anti-spam library
https://tg-spam.umputun.dev
MIT License
211 stars 36 forks source link

Add deletion of noisy system messages #72

Closed Systemnick closed 6 months ago

Systemnick commented 6 months ago

Flag enables delete system messages, that can be treated like spam (user added/removed, message pinned, etc)

umputun commented 6 months ago

Thanks for the PR. There are several technical problems here that probably can be addressed (i.e., missing tests, using/extending admin functionality in an unexpected way, presence of commented code...), but all of this is not the major issue. The major issue - it doesn't seem to do anything with spam detection. What this change does, unless I missed the point - it eliminates pretty much all the system messages regardless of the spam or not, just all of them.

This functionality is probably a valid one, but it doesn't seem to be a part of the issue what tg-spam is trying to address - spam detection and reaction. Theoretically, it can be a part of spam detection in a very limited scope (i.e., emoji count for example in joined user names) but not much else.

If the goal is to completely suppress all the system messages, to me it seems to be a task for a different bot, if such a bot doesn't exist yet.