search

umr-lops / L2A-wind-direction-processor

Python package to generate Level-2A wind direction files from Sentinel-1 TOPS product based on low frequency texture analysis.
MIT License
4 stars 0 forks source link

the variable used for prediction is currently `sigma0` it should be `sigma0_filt` #12

Closed agrouaze closed 6 months ago

agrouaze commented 6 months ago

If we look at https://github.com/umr-lops/L2A-wind-direction-processor/blob/4a17e91f7442b146072f7d78768c4651e3f0d886/l2awinddirection/generate_L2A_winddir_pdf_product.py#L44 we can see that sigma0 is used for the prediction. In the meatime the Level-1B product evolved and introduced a sigma0_filt variable with (denoising and bright target correction) also it is NaN for the tiles with land while sigma0 in the latest version of the L1B product is always defined. So I suggest to replace sigma0 by sigma0_filt.

agrouaze commented 6 months ago

@rmarquarlops Are you OK with this proposition?

agrouaze commented 6 months ago

In fact the code in xsarslc to generate the tiles do not have yet the sigma0_filt variable. (This evolution is foreseen in any case). So for now we will continue with sigma0 and land_flag. see https://github.com/umr-lops/xsar_slc/blob/0a200b7a84017ca32580ae0f303ff9134a4f490d/xsarslc/interface.py#L74