umr-lops / L2A-wind-direction-processor

Python package to generate Level-2A wind direction files from Sentinel-1 TOPS product based on low frequency texture analysis.
MIT License
4 stars 0 forks source link

heading angle is taken into account for the basic regression but not for "pdf" prediction. #13

Closed agrouaze closed 6 months ago

agrouaze commented 6 months ago

looking at the code for basic regression https://github.com/umr-lops/L2A-wind-direction-processor/blob/4a17e91f7442b146072f7d78768c4651e3f0d886/l2awinddirection/generate_L2A_winddir_regression_product.py#L40 The predicted angle is "corrected" from the heading angle. It is seems that heading_angle is not use at all in the "pdf" version. To me it looks like a forgetfulness. @rmarquarlops do you confirm?