umr-lops / grdwindinversion

python library to compute wind speed from GRD SAR images
https://cerweb.ifremer.fr/datarmor/doc_sphinx/grdwindinversion/index.html
MIT License
9 stars 1 forks source link

check content of owiNrcs_no_noise_correction var #48

Closed vincelhx closed 8 months ago

vincelhx commented 8 months ago

6d271cec2adf40d4220802de1a205fa7492efbf0

agrouaze commented 8 months ago

Hello @vincelhx , This issue was a typo or the variable names were not clear enough? I remember that at some point we used the "co-GMF" for cross channels inversion because the "cross-GMF" was not available. It is a related problem? BTW I prefer that we always go through pull request, even for very small modifications like this. It is much easier then when you want to track the differences between releases.

vincelhx commented 8 months ago

Hi @agrouaze

I grdwindinversion, i (wrongly) recreated owiNrcs_no_noise_correction or owiNrcs_cross_no_noise_correction but it was already in L1-products with sigma0_raw var. What we did for HH/HV products is that we temporarly use VV/VH GMFs. but it's unrelated.

Ok, i will now use a fork