search

umr-lops / xsar

Synthetic Aperture Radar (SAR) Level-1 GRD python mapper for efficient xarray/dask based processing
https://cyclobs.ifremer.fr/static/sarwing_datarmor/xsar/
MIT License
29 stars 8 forks source link

clearing things up in burst #108

Closed lanougue closed 2 years ago

lanougue commented 2 years ago

Hello guys I am jumping in xsar ! and already have some request / comment. Here it is: when I request "s1ds.s1meta.bursts()" I get a panda dataframe (that I just always transform in xarray) with missing information that I can find in "s1ds.s1meta._burst" which is indeed an xarray.Dataset ! Why don't just create a simple xarray Dataset with informations of both the two entities pre-cited that I can call easily call as "s1ds.s1meta.burst"? They all have common dimensions ! (and name could stay singular -burst- as in original xml file)

By the way, looking in attributes of "s1ds.s1meta._bursts", why linesPerBurst and "samplesPerBurst" have been renamed in "atrack_per_burst" and "xtrack_per_burst" ? Initial name is more logic/understandable for me and they may be stored as variable and not as attributes

lanougue commented 2 years ago

In fact, the final xarray.Dataset would look like the same as if I currently compute burst = xr.merge([s1ds.s1meta.bursts().to_xarray(),s1ds.s1meta._bursts], combine_attrs='no_conflicts')

agrouaze commented 2 years ago

closed with #118 .