umr-lops / xsar

Synthetic Aperture Radar (SAR) Level-1 GRD python mapper for efficient xarray/dask based processing
https://cyclobs.ifremer.fr/static/sarwing_datarmor/xsar/
MIT License
24 stars 8 forks source link

Antimeridian crossing not yet checked for RS2 product #172

Open agrouaze opened 12 months ago

agrouaze commented 12 months ago

trying to read datawork-cersat-public/cache/project/sarwing/data/RS2/L1/VV_VH/2022/013/RS2_OK133121_PK1162214_DK1119226_SCWA_20220113_173154_VV_VH_SGF

File "/home1/datahome/agrouaze/sources/git/grdwindinversion/grdwindinversion/inversion.py", line 179, in makeL2
    xsar_obj_1000m = fct_dataset(meta, resolution='1000m')
  File "/home1/datahome/agrouaze/sources/git/xsar/src/xsar/radarsat2_dataset.py", line 216, in __init__
    rasters = self._load_rasters_vars()
  File "/home1/datahome/agrouaze/sources/git/xsar/src/xsar/utils.py", line 94, in wrapper
    result = f(*args, **kwargs)
  File "/home1/datahome/agrouaze/sources/git/xsar/src/xsar/base_dataset.py", line 816, in _load_rasters_vars
    raise NotImplementedError('Antimeridian crossing not yet checked')

@yreynaud is this method forgotten for RS2 products?

agrouaze commented 12 months ago

issue not yet fixed but at least PR #173 will help

  1. the error raised to users is more clear
  2. the comments in the code don't let think that it is a typo but simply a not implemented feature for raster methods.