search

umr-lops / xsar

Synthetic Aperture Radar (SAR) Level-1 GRD python mapper for efficient xarray/dask based processing
https://cyclobs.ifremer.fr/static/sarwing_datarmor/xsar/
MIT License
24 stars 8 forks source link

reverse calibration lut && include kersten recalibration #184

Closed vincelhx closed 6 months ago

vincelhx commented 7 months ago

yes at this point it shoud raise an Error

vincelhx commented 7 months ago

Hi. Now it raises an Error

agrouaze commented 6 months ago

@vincelhx Is possible to add the xsar.open_dataset times from develop branch and the ones from your branch with and without recalibration applied? Is your re-calibration working for WV, SM ,EW too ?

vincelhx commented 6 months ago

its working for GRD only : i add an exception? what do you mean by xsar.open_dataset̀ times?

agrouaze commented 6 months ago

its working for GRD only : i add an exception?

WV cannot be produced as GRD but SM and EW are available in GRD, so I guess that re-calibration should work the same way for all acquisition modes. Correct? It is not the case or if it is not yet implemented we need to clarify it in the code and in the doc.

what do you mean by xsar.open_dataset̀ times?

I simply mean the time that opening a product takes, to comapre before/after with/without your re-calibration.

vincelhx commented 6 months ago

to open a new recalibrated dataset : s1ds_recal = xsar.Sentinel1Dataset(L1_path,resolution='1000m',recalibration=True)

if no roll angle ( no recalibration ) => ValueError: Recalibration can't be done without roll angle. You probably work with an old file for which roll angle is not auxiliary file.

only for EW/IW

vincelhx commented 6 months ago

var concerned : INTEREST_VAR = ["sigma0_raw","gamma0_raw","beta0_raw"] (l660 from sentinel1_dataset.py)

vincelhx commented 6 months ago

no change in .dataset : excepted an attribute to comment if recalib was applied or not image

vincelhx commented 6 months ago

new datatree related to recalibration steps : maybe it need to be completed or detailed.

image

vincelhx commented 6 months ago

mean times to xsar.Sentinel1Dataset(L1_path, resolution = '1000m')

before commit without recalibration : Mean time for S1A_IW_GRDH_1SDV_20141231T150741_20141231T150810_003965_004C59_FA9B : 4.936 secondes Mean time for S1B_EW_GRDM_1SDV_20190306T135326_20190306T135430_015234_01C808_DE3D : 4.156 secondes

after commit without recalibration : Mean time for S1A_IW_GRDH_1SDV_20141231T150741_20141231T150810_003965_004C59_FA9B : 4.525 secondes Mean time for S1B_EW_GRDM_1SDV_20190306T135326_20190306T135430_015234_01C808_DE3D : 6.172 secondes this is due to changes in xarray-safe-s1 https://github.com/umr-lops/xarray-safe-s1/pull/15

after commit with recalibraton S1A_IW_GRDH_1SDV_20141231T150741_20141231T150810_003965_004C59_FA9B : error (old file) Mean time for S1B_EW_GRDM_1SDV_20190306T135326_20190306T135430_015234_01C808_DE3D : 6.067 secondes