Closed sherson closed 9 years ago
Also, I'll mention to Avail that &
isn't dealt with properly in their XML.
Probably this break;
isn't supposed to be there?
The break;
definitely shouldn't have been there, though that wasn't the issue here. The issue was that loadMessages
was being called once per table load, which happens multiple times per refresh, and it was only considering the route_ids
from the last one (which is why you see that switching the order breaks it). I've implemented a solution here.
:+1:
When rendering multiple stops, it display alerts only for the last stop. For example, http://umts.github.io/BusInfoBoard/?&mobile=true&stops=73+63 displays the alerts for stop 63. If I swap 73 and 63, I see alerts for 73.
Also, if there is an alert in the feed that is not route specific, at least the next route specific alert in the feed does not appear.
For instance, the Move-Out Day alert (
70
) below is not route specific:The commencement alert (
71
) was not appearing. Once I made Move-Out Day routes-specific, the commencement alert appeared.(of course, that Move-Out Day should've been specific to Routes 34 and 35... and both 34/35 alerts shouldn't be there anyway as shuttle ended yesterday, so I've removed them)