search

umts / BusInfoBoard

A place to view bus arrival information from Avail's JSON feed
Apache License 2.0
16 stars 3 forks source link

Auto-load all stops #30

Closed akaplo closed 8 years ago

akaplo commented 8 years ago

I updated the BusInfoBoard's StopSelector page to automatically download and allow users to search through/choose from all of PVTA's stops. Previously, you had to select a route and then scroll through or type in a stop name. I made it easier to skip that step (and people don't know that you can type to search for routes/stops, so I made that a little clearer too).

sherson commented 8 years ago

Looks great, thanks!

That written, let's go through it a little more in the next code review (@werebus mentioned we should tweak a few things).

werebus commented 8 years ago

In the future, lets try to get this code in front of a code-review before deploying it.

sherson commented 8 years ago

In the future, lets try to get this code in front of a code-review before deploying it.

Yeah, that was my bad (obviously).

akaplo commented 8 years ago

I've updated some (most) of the things that @werebus mentioned and pushed them to my fork. I'm never around for our scheduled code reviews but whenever I'm present and you guys have time, doing a code review would be great!

werebus commented 8 years ago

So, two non-nit-pick things to mention:

  1. The flow of the page is a little haphazard: -----Thing1----- OR Thing2 [optional] OR/Now Thing3. I'm not sure what I would've done differently, though.

  2. One problem with a list of all stops is stuff like this:

    screenshot_2015-11-16_13-54-04

    Because they're actually different stops, only one of those "Berkshire / Elizabeth" stops is the one that they want. This is pretty much PVTA's fault, but...