search

umts / BusInfoBoard

A place to view bus arrival information from Avail's JSON feed
Apache License 2.0
15 stars 3 forks source link

Times incorrect in ILC? #62

Closed werebus closed 7 years ago

werebus commented 7 years ago

Departure estimates are correct, but the "actual" time of the departure appears to be off by 5 hours. 5 hours is an interesting amount of time to be off by, perhaps the new code in #54 is not dealing with the machine locale correctly? There's a chance that the time-zone on the RPi is UTC...?

dfaulken commented 7 years ago

perhaps the new code in #54 is not dealing with the machine locale correctly?

Hmm, I know how to "fix" this, but it seems undesirable to write our code to effectively infer its timezone from the timezone in the timestamps in the Avail endpoint data rather than the timezone the machine's set to be in. That is, if our Avail endpoint's on one side of Indiana, returning times local to it, and we're on the other side of Indiana, shouldn't we display local (to the kiosk) times when buses are coming?

Is the real bug here not that the RPi is localized to somewhere other than where it actually lives? Or am I off base?

sherson commented 7 years ago

The pi was set to UTC. As a temporary fix, I changed it to EDT via ssh and sudo raspi-config.

Talked to the RO and got confirmation from a driver that the times on the sign are currently correct.

werebus commented 7 years ago

Yes, you're correct. I think.

I opened this bug on the way out the door to make sure it was documented, but I think that the behavior is actually correct.

I'll take a look tomorrow.

On Apr 12, 2017 21:00, "David Faulkenberry" notifications@github.com wrote:

Hmm, I know how to "fix" this, but it seems undesirable to write our code to infer its timezone from the timezone in the timestamps in the Avail endpoint data rather than the timezone the machine's set to be in. That is, if our Avail endpoint's on one side of Indiana, returning times local to it, and we're on the other side of Indiana, shouldn't we display local (to the board) times when buses are coming?

Is the real bug here not that the RPi is localized to somewhere other than where it actually is? And that our interval parsing functions just assumes the timezones are the same? Or am I off base here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/umts/BusInfoBoard/issues/62#issuecomment-293747942, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOqk1o6GJIeogPmZEunIKvvIbzfzfmWks5rvXObgaJpZM4M8BgH .

werebus commented 7 years ago

Fixed by @sherson.

I think the behavior of "show the departure localized to wherever the board is located" is arguably correct. Even though it's probably a rare occurrence that a departure board and the transit agency are in two different time zones.