umts / BusInfoBoard

A place to view bus arrival information from Avail's JSON feed
Apache License 2.0
15 stars 3 forks source link

Use `display: grid` instead of BootStrap's rows #82

Open bandogora opened 1 year ago

bandogora commented 1 year ago

Fixing the overlapping of columns when zoomed in.

dirschn commented 1 year ago

An issue I have with this is that when loading in if there's more than one stop and it spills into a second column, it starts loading into a single column and then suddenly splits into a second column. Currently in master it seems to account for the second column from the beginning and loads the first stop at half width to begin with

bandogora commented 1 year ago

An issue I have with this is that when loading in if there's more than one stop and it spills into a second column, it starts loading into a single column and then suddenly splits into a second column. Currently in master it seems to account for the second column from the beginning and loads the first stop at half width to begin with

I see what you're talking about. I'm not quite sure how to fix that since the behavior is defined by CSS. The problem comes from the behavior of not wanting 2 columns if there is only one departure.

dirschn commented 1 year ago

Does it absolutely have to have an animation? What if you just remove that?

bandogora commented 1 year ago

Does it absolutely have to have an animation? What if you just remove that?

That seems a little out of the scope of this PR.